fix(ios): handle location watch callbacks recovery after backgrounding#30
Merged
Conversation
andredestro
approved these changes
Jun 16, 2025
Contributor
|
Still have to review the changes themselves, but would this same fix also make sense for the Cordova plugin? |
Contributor
Author
Yes it probably makes sense to also make this change to the Cordova plugin since the same issue exists |
OS-pedrogustavobilro
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #19
This PR fixes iOS
watchPositionrecovery after backgrounding the app. Previously the plugin would throw an error and stop monitoring location updates. Now it will handle the error gracefully and restart the monitoring when the app becomes active again.Context
#19
Type of changes
Platforms affected
Tests
Tested with https://github.com/nharrer/ionic-geo-location